kwin commented on code in PR #376:
URL: 
https://github.com/apache/jackrabbit-filevault/pull/376#discussion_r2216669981


##########
vault-core/src/main/java/org/apache/jackrabbit/vault/util/EffectiveNodeType.java:
##########
@@ -68,6 +71,8 @@ public final class EffectiveNodeType {
 
     private EffectiveNodeType(@NotNull List<NodeType> nodeTypes) {
         this.nodeTypes = nodeTypes;

Review Comment:
   I think we then no longer need nodeTypes as field of this classs. This 
requires refactoring of `equals` and `hashCode` to only consider 
propertyDefinitions/nodeDefinitions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to