kwin commented on code in PR #378: URL: https://github.com/apache/jackrabbit-filevault/pull/378#discussion_r2325633131
########## vault-core-it/vault-core-integration-tests/src/main/resources/test-packages/tmp-content-outside-filters.zip: ########## Review Comment: Let's use non binary packages (i.e. exploded ones, as can be seen e.g. in https://github.com/apache/jackrabbit-filevault/tree/master/vault-core-it/vault-core-integration-tests/src/main/resources/test-packages/import_modes_test_filehandler.zip) ########## vault-core/src/main/java/org/apache/jackrabbit/vault/fs/config/DefaultWorkspaceFilter.java: ########## @@ -241,6 +241,10 @@ public void setSkipFilterChecksOnImport(boolean skipFilterChecksOnImport) { this.skipFilterChecksOnImport = skipFilterChecksOnImport; } + public boolean getSkipFilterChecksOnImport() { Review Comment: No need to add new methods/fields to WorkspaceFilter then, just use the one from ImportOptions directly (i.e. pass as boolean argument to `DocViewImporter` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
