kwin commented on code in PR #378:
URL:
https://github.com/apache/jackrabbit-filevault/pull/378#discussion_r2337078789
##########
vault-core-it/vault-core-integration-tests/src/main/java/org/apache/jackrabbit/vault/packaging/integration/ImportIT.java:
##########
@@ -445,4 +445,55 @@ public void
testEnhancedFileAggregatePackageWithIntermediateSaves() throws IOExc
assertPropertyExists("/testroot/tika/config.xml/jcr:content/jcr:data");
assertProperty("/testroot/tika/config.xml/jcr:content/jcr:mimeType",
"text/xml");
}
+
+ @Test
+ public void testSkipFilterChecksOnImport_disabled() throws Exception {
+ ImportOptions opts = getDefaultOptions();
+ Importer importer = new Importer(opts);
+ try (Archive archive =
getFileArchive("/test-packages/outside-filters.zip")) {
+ archive.open(true);
+ importer.run(archive, admin.getRootNode());
+ admin.save();
+ }
+ assertNodeExists("/tmp/foo");
+ assertPropertyMissing("/tmp/foo/bar/tobi/excludeddProp");
Review Comment:
Please add some assertions what happens to nodes/properties below filter
roots not contained in the package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
