kwin commented on code in PR #409:
URL:
https://github.com/apache/jackrabbit-filevault/pull/409#discussion_r2710132580
##########
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/AggregateImpl.java:
##########
@@ -719,10 +737,15 @@ private void prepare(Node node, boolean descend) throws
RepositoryException {
// get a node iterator suitable for the current node and the
applicable filters
NodeIterator nIter = getNodeIteratorFor(node, filter);
+ log.debug("starting aggregate walk of '{}'", this.path);
+ int visited = 0;
+ long startTime = System.nanoTime();
Review Comment:
Why measure in nanos when emitting in ms only?
##########
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/AggregateImpl.java:
##########
@@ -780,6 +803,14 @@ private void prepare(Node node, boolean descend) throws
RepositoryException {
}
}
}
+
+ Duration duration = Duration.ofNanos(System.nanoTime() - startTime);
Review Comment:
No need for Duration an time conversion if measuring in millis in the first
place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
