reschke commented on code in PR #412: URL: https://github.com/apache/jackrabbit-filevault/pull/412#discussion_r2730350091
########## vault-core/src/test/java/org/apache/jackrabbit/vault/fs/io/ZipArchiveCloseTest.java: ########## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.jackrabbit.vault.fs.io; + +import java.io.File; +import java.io.FileOutputStream; +import java.io.IOException; +import java.net.URISyntaxException; +import java.nio.file.Paths; +import java.util.zip.ZipEntry; +import java.util.zip.ZipOutputStream; + +import org.apache.jackrabbit.vault.packaging.PackageId; +import org.apache.jackrabbit.vault.packaging.impl.ZipVaultPackage; +import org.junit.BeforeClass; +import org.junit.Rule; +import org.junit.Test; +import org.junit.rules.TemporaryFolder; + +import static org.junit.Assert.assertNull; + +/** + * Test to demonstrate JCRVLT-838. + * + * The test case does not use the use the JcrPackageManagerImpl.assemble(Node, JcrPackageDefinition, ProgressTrackerListener) + * call as shown in the ticket, but it resembles the major steps from that method. + * + * The exception is triggered by an invalid XML in this test, but there could be other reasons as well. + * + */ +public class ZipArchiveCloseTest { + + @Rule + public TemporaryFolder tempFolder = new TemporaryFolder(); + + @BeforeClass + public static void setUpOnce() throws URISyntaxException { + // Disable stack traces for cleaner output + System.setProperty(AbstractArchive.PROPERTY_ENABLE_STACK_TRACES, "false"); Review Comment: Do we need to preserve/restore the previous value here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
