kwin commented on code in PR #414:
URL:
https://github.com/apache/jackrabbit-filevault/pull/414#discussion_r2792488898
##########
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/Importer.java:
##########
@@ -1036,8 +1039,132 @@ private void commit(Session session, TxInfo info,
LinkedList<TxInfo> skipList)
}
}
+ /**
+ * Restores the coverage filter on the artifact set from the aggregator
configuration.
+ * This is necessary because the coverage filter metadata is lost during
the archive→import flow.
+ *
+ * The coverage filter determines which child nodes are "covered" by this
aggregate and should
+ * be removed if not present in the package. Aggregators with partial
coverage (e.g., folder
+ * aggregates with {@code <exclude isNode="true" />}) should preserve
child nodes that are
+ * outside their coverage.
+ *
+ * This method only applies the filter when there are child aggregates
(hints), which indicates
Review Comment:
Right, but I wanted to express was: It should behave the same no matter
which aggregate was chosen for the export. As I outlined in
https://issues.apache.org/jira/browse/JCRVLT-830?focusedCommentId=18050655&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-18050655
this can also occur for potentially setups which just leverage full coverage
aggregates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
