[ 
https://issues.apache.org/jira/browse/JCR-5207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18059313#comment-18059313
 ] 

Julian Reschke commented on JCR-5207:
-------------------------------------

Occasional test fail in PR:

{code}
junit.framework.AssertionFailedError: junit.framework.AssertionFailedError: 
expected:<478> but was:<479>
        at junit.framework.Assert.fail(Assert.java:57)
        at junit.framework.TestCase.fail(TestCase.java:223)
        at 
org.apache.jackrabbit.core.LockedWrapperTest.testSequenceWithSessionRefresh(LockedWrapperTest.java:288)
        at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:566)
        at junit.framework.TestCase.runTest(TestCase.java:177)
        at junit.framework.TestCase.runBare(TestCase.java:142)
        at junit.framework.TestResult$1.protect(TestResult.java:122)
        at junit.framework.TestResult.runProtected(TestResult.java:142)
        at junit.framework.TestResult.run(TestResult.java:125)
        at org.apache.jackrabbit.test.JCRTestResult.run(JCRTestResult.java:75)
        at junit.framework.TestCase.run(TestCase.java:130)
        at 
org.apache.jackrabbit.test.AbstractJCRTest.run(AbstractJCRTest.java:475)
        at junit.framework.TestSuite.runTest(TestSuite.java:241)
        at junit.framework.TestSuite.run(TestSuite.java:236)
        at junit.framework.TestSuite.runTest(TestSuite.java:241)
        at 
org.apache.jackrabbit.test.ConcurrentTestSuite.access$001(ConcurrentTestSuite.java:29)
        at 
org.apache.jackrabbit.test.ConcurrentTestSuite$2.run(ConcurrentTestSuite.java:67)
        at EDU.oswego.cs.dl.util.concurrent.PooledExecutor$Worker.run(Unknown 
Source)
        at java.base/java.lang.Thread.run(Thread.java:829)
{code}

> Deprecate TransientFileFactory (also add test hook)
> ---------------------------------------------------
>
>                 Key: JCR-5207
>                 URL: https://issues.apache.org/jira/browse/JCR-5207
>             Project: Jackrabbit Content Repository
>          Issue Type: Task
>          Components: jackrabbit-jcr-commons
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>
> - it depends on GC and/or shutdown hooks and thus is not predictable
> - it still potentially leaks files
> - it hides coding errors
> - code that relies on files not being removed may break when the cleanup 
> actually runs early



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to