kwin commented on code in PR #416:
URL:
https://github.com/apache/jackrabbit-filevault/pull/416#discussion_r2878918572
##########
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/api/WorkspaceFilter.java:
##########
@@ -182,4 +182,25 @@ void dumpCoverage(@NotNull Session session, @NotNull
ProgressTrackerListener lis
* @return {@code true} if the property is included in the filter
*/
boolean includesProperty(String propertyPath);
+
+ /**
+ * Returns whether the given path's subtree is supposed to be fully
overwritten during import,
+ * by traversing the repository and checking that every node and property
in the subtree is
+ * included by this filter. Returns {@code true} only when:
+ * <ul>
+ * <li>the path is covered by this filter and import mode is {@link
ImportMode#REPLACE},</li>
Review Comment:
That was not what I was implying. I would go without Session/Node (and any
JCR operations in this class)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
