rishabhdaim commented on code in PR #448:
URL:
https://github.com/apache/jackrabbit-filevault/pull/448#discussion_r4294513588
##########
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/config/ConfigHelper.java:
##########
@@ -64,6 +64,30 @@ public String getDefaultClass(String name) {
public Object create(Element elem)
throws ConfigurationException {
+ return create(elem, Object.class);
+ }
+
+ /**
+ * Creates a configured instance after checking its type without
initializing the class.
+ * Static field access using {@code Class#FIELD} is not allowed.
+ *
+ * @param elem the config element, must not be {@code null}
+ * @param expectedType the required class type, must not be {@code null}
+ * @return the new instance, or the element's text content if no class is
configured
+ * @throws ConfigurationException if the class cannot be resolved, is not
assignable to
+ * {@code expectedType}, uses the rejected {@code #} field syntax,
or cannot be
+ * instantiated
+ * @throws IllegalArgumentException if either argument is {@code null}
+ * @since 2.6.0 (Bundle version 3.2.9)
Review Comment:
```suggestion
```
##########
parent/pom.xml:
##########
@@ -153,6 +153,10 @@
</goals>
<configuration>
<failOnError>true</failOnError>
+ <filters>
+ <!-- Avoid version increase for continued
consistency with master branch -->
+
<filter>!org.apache.jackrabbit.vault.fs.confi</filter>
Review Comment:
```suggestion
<filter>!org.apache.jackrabbit.vault.fs.config</filter>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
