kwin commented on code in PR #452: URL: https://github.com/apache/jackrabbit-filevault/pull/452#discussion_r4392033442
########## vault-validation/src/main/java/org/apache/jackrabbit/vault/validation/spi/impl/PackageIdValidator.java: ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.jackrabbit.vault.validation.spi.impl; + +import java.util.Collection; +import java.util.Collections; + +import org.apache.jackrabbit.vault.packaging.PackageId; +import org.apache.jackrabbit.vault.packaging.PackageProperties; +import org.apache.jackrabbit.vault.validation.spi.PropertiesValidator; +import org.apache.jackrabbit.vault.validation.spi.ValidationMessage; +import org.apache.jackrabbit.vault.validation.spi.ValidationMessageSeverity; +import org.jetbrains.annotations.NotNull; +import org.jetbrains.annotations.Nullable; + +public final class PackageIdValidator implements PropertiesValidator { + + protected static final String MESSAGE_INVALID_OR_MISSING_PACKAGE_ID = + "Package id is missing or invalid. Make sure properties 'group', 'name' and optional 'version' are set to valid values."; + + private final ValidationMessageSeverity severity; + + public PackageIdValidator(@NotNull ValidationMessageSeverity severity) { + this.severity = severity; + } + + @Override + public @Nullable Collection<ValidationMessage> validate(@NotNull PackageProperties properties) { + PackageId id = properties.getId(); + if (id == null || !id.isValid()) { + // TODO: improve error message to validate each part of a package id individually and emit valid format for Review Comment: This requires to expose a `isValidName()`, `isValidGroup()` and `isValidVersion()` from PackageId which should be internally called from `isValid()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
