Mauro Talevi wrote:
Hi all,
just a heads up to say that I've cleaned up story printer and runner to:
- use StoryLoader as central point of story loading, both from class
name and from rendered story,
backward compatible with default ctors of StoryPrinter/Runner using
the text-based StoryLoader.
- tucked in all checked exceptions thrown in loading of classes into a
runtime InvalidStoryClassException - backward compatible if the client
was catching Exception.
- Changed StoryRunner#run(*, PrintStream) to StoryRunner#run(*,
OutputStream) - backward compatible.
One thing I'm in two minds about is whether StoryRunner#run(*,
OutputStream) methods should not really be StoryRunner#run(*,
BehaviourListener), as ultimately it's the listener to which we
delegate the printing. With current impl, it's hardcoded to use
PlainTextScenarioListener, but there is really no reason why it should
be hardcoded.
Coupling the run method to a stream is just bad design. Whoever came up
with that should be shot. *cough*
Feel free to make it take a listener instead.
Thoughts?
Cheers
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
