I just thought from the earlier conversations that we are on 1.5. Sorry (On the other hand, the generics were just language level, you can always compile it for the target of 1.4. )
At the same time, I am at lost here... Removing the generics usage should be a lot better than simply revert all the changes? Just compile and fix. For me to reapply it now, I'll have to go through each file manually, revert the revert, and remove the change. About the argument for scanning behaviours, I am sorry but are you saying that you want to use Ant or Maven classes, something that is more complicated and less tested, rather than use Cotta, something much smaller and designed just for directory and file operations, and fully tested? Like I said, Cotta works with class files, so it does not matter where your source it, and it works if the classes are in a jar file instead of directory. And I did leave it out of the code, it is on test only. Shane On 9/7/07, Mauro Talevi <[EMAIL PROTECTED]> wrote: > Elizabeth Keogh wrote: > > Hi Shane, > > > > I've reverted your change, which contains generics. Maybe when we make > > the move to using Java 5 we can revisit this, but it won't be until > > JBehave 2.0. I would also like to keep Cotta out of the codebase, please. > > Agreed we should keep jBehave 1.x JDK1.4 compat, although we should really > start considering 2.x > branch with JDK 5+. > > > There is a different solution! I have always intended to make the Ant > > build use Ant's scanner to find all the behaviours, and only verify the > > Ant task behaviours separately. This is a great spur for me to do that, > > this weekend. It already works (see the Hellbound behaviours); just need > > to get on and do it. This approach has scaled on every JUnit project > > I've been on, and allows coolness like forking the vm. > > > > Apologies for not being involved in the discussion earlier, and thanks > > for calling it in. > > > > Mauro, is there anything similar for Maven? If so, we can remove the > > AllBehaviours completely. > > I use Ant's DirectoryScanner in Maven's Fit plugin to list files from a given > source dir. > But these are file paths, not classes in a classpath. Not sure how you > achieve that for classes. > Do you have an idea in mind? > > I see the necessity perhaps of defining a util class - eg ScannedBehaviours > (or a better name :-) - > which uses a tool under the hood, be it Ant's or Cotta or whatever. I don't > have any preclusion to > Cotta (or to any other dep) as long as the dependency is well encapsulated > and optional for the core. > > Cheers > > > > > --------------------------------------------------------------------- > To unsubscribe from this list please visit: > > http://xircles.codehaus.org/manage_email > > -- Shane http://www.shaneduan.com --------------------------------------------------------------------- To unsubscribe from this list please visit: http://xircles.codehaus.org/manage_email
