Hi Liz, I think it is better to explain it here than let it lost in the chat.
As I have mentioned when I submitted the patch for review. The fix is not about generics, it is about removing an unused field that is causing confusing every item I looked at that class. Generics was a side effect when I was fixing the warnings, because I didn't read the mails correctly (I really thought we were on Java5, sorry). As for the AllBehaviour implementation, what I saw was a set of code that are very error-prone. I was actually surprised to see it still there because from the emails that I read I thought we were going to use Ant's file scanning. Since that is not the case, I put in something that is better that what it is. That is all. I understand some have different preference, which is fine with me. Just that leaving the way AllBehaviour is implemented for almost a year is not a good thing. I'd rather implement it with something better even that means it will be changed. I still disagree with the way this is handled (fix vs revert) but I respect your decision. BTW, there are code using Java5 API's in the existing code. You probably need to check your project setting. Cheers Shane On 9/9/07, Elizabeth Keogh <[EMAIL PROTECTED]> wrote: > -----"Shane Duan" <[EMAIL PROTECTED]> wrote: ----- > > FYI: The change to the build file is now in. > > >I just thought from the earlier conversations that > we are on 1.5. > >Sorry (On the other hand, the generics were > just language level, you > >can always compile it for the target of 1.4. ) > > If we ever make this change, some warning will be nice; I am currently > compiling with a 1.4 compiler so it falls over for me. There may be others > out there doing the same. > > >Removing the generics usage should be a lot better > than simply revert > >all the changes? Just compile and fix. > > The generics usage was only one of the problems; I made a big deal of it to > remind everyone that we were still on 1.4 (I've accidentally used 1.5 APIs > in the past, so you're not the only one). > > >For me to reapply it now, > >I'll have to go through each file manually, revert > the revert, and > >remove the change. > > In my despotic opinion, the code isn't needed. Please feel free to ping me > if you really believe that's not the case. > > In any case, you can revert all the changes from an entire revision (r796 is > my revert, which you could revert in turn). This is especially easy if > you're using Windows and Tortoise. > > >About the argument for scanning behaviours, I > am sorry but are you > >saying that you want to use Ant or Maven classes, > something that is > >more complicated and less tested, > > The ant tasks are all fairly uncomplicated, TBH. I didn't write the original > BehaviourRunners, just extended them for the story running and printing and > found it fairly easy. > > As for being less tested, I've used filesets in every Enterprise app I've > worked on. There's no substitute for testing in the real world! The ant > filesets have been tested in JBehave's build since the examples went into > the main build targets, anyway. > > >rather than use Cotta, something > >much smaller and designed just for directory and > file operations, and > >fully tested? Like I said, Cotta works with class > files, so it does > >not matter where your source it, and it works if > the classes are in a > >jar file instead of directory. > > I 'stole' the bit of code which allowed .java, .class and jarred files. It > was extremely valuable, so thank you very much for that. > > >And I did leave it out of the code, it is on test only. > > Please remember that if we need something in order to use JBehave > effectively, our users will need it too. It's even worse to provide a > solution for ourselves, then keep it from the users, than it is to simply > put it in the jar. And I'd rather not, at this stage, put Cotta in the jar. > > If you want to talk to me more about this, please feel free to email > off-list or ping me on Yahoo. > > Cheers, > Liz. > > -- > Elizabeth Keogh > [EMAIL PROTECTED] > http://sirenian.livejournal.com > http://jbehave.org > --------------------------------------------------------------------- > To unsubscribe from this list please visit: > http://xircles.codehaus.org/manage_email -- Shane http://www.shaneduan.com --------------------------------------------------------------------- To unsubscribe from this list please visit: http://xircles.codehaus.org/manage_email
