[
http://jira.codehaus.org/browse/JBEHAVE-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=224967#action_224967
]
Brian Repko commented on JBEHAVE-307:
-------------------------------------
Not sure if this is a related issue or not.
The following method change would make more sense in AbstractStory
protected StoryEmbedder configuredEmbedder() {
embedder.useConfiguration(getConfiguration());
embedder.useCandidateSteps(getSteps());
return embedder;
}
While the getters are no longer part of the interface, they could be protected
and part of the AbstractStory.
This allows a user to configure a story via overriding.
Thus the options for story configuration are:
1. Constructor
2. Lifecycle method (@Before)
3. Overriding getter methods
This is important for use with IoC containers as they should not be started up
in the constructor of the test class but rather as part of the running of the
test.
> Remove redundant getter methods in RunnableStory
> ------------------------------------------------
>
> Key: JBEHAVE-307
> URL: http://jira.codehaus.org/browse/JBEHAVE-307
> Project: JBehave
> Issue Type: Improvement
> Components: Core
> Reporter: Mauro Talevi
> Assignee: Mauro Talevi
> Priority: Minor
> Fix For: 3.0
>
>
> RunnableStory getter methods are now redundant. They could lead to confusion
> as users may override them believing they would be used by the story embedder.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
