[
https://jira.codehaus.org/browse/JBEHAVE-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=287022#comment-287022
]
Alexander Lehmann edited comment on JBEHAVE-688 at 12/28/11 3:54 PM:
---------------------------------------------------------------------
I think this case is not covered by the tests, when I add
assertFilterAllowsProperty("-skip", "skip true", false);
the test fails
was (Author: alexlehm):
I think this case is not covered by the tests, when I add
assertFilterAllowsProperty("-skip", "skip true", false); the test fails
.../jbehave/core/embedder/MetaFilterBehaviour.java | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git
a/jbehave-core/src/test/java/org/jbehave/core/embedder/MetaFilterBehaviour.java
b/jbehave-core/src/test/java/org/jbehave/core/embedder/MetaFilterBehaviour.java
index d2f1ec1..4d7e758 100755
---
a/jbehave-core/src/test/java/org/jbehave/core/embedder/MetaFilterBehaviour.java
+++
b/jbehave-core/src/test/java/org/jbehave/core/embedder/MetaFilterBehaviour.java
@@ -54,6 +54,13 @@ public class MetaFilterBehaviour {
assertFilterAllowsProperty("-skip", "skip", false);
assertFilterAllowsProperty("+theme smoke testing -theme UI", "theme
smoke testing", true);
assertFilterAllowsProperty("+theme smoke testing -theme UI", "theme
UI", false);
+ assertFilterAllowsProperty("-skip", "skip true", false);
+ assertFilterAllowsProperty("-skip", "skip false", true);
+ assertFilterAllowsProperty("-skip true", "skip true", false);
+ assertFilterAllowsProperty("-skip true", "skip false", true);
+ // doesn't make any sense, but should work nonetheless
+ assertFilterAllowsProperty("-skip false", "skip true", true);
+ assertFilterAllowsProperty("-skip false", "skip false", false);
}
@Test
> metaFilters "-skip" doesn't work while "-skip true" works
> ---------------------------------------------------------
>
> Key: JBEHAVE-688
> URL: https://jira.codehaus.org/browse/JBEHAVE-688
> Project: JBehave
> Issue Type: Bug
> Components: Core
> Affects Versions: 3.5.4
> Environment: windows 7, java 1.6.0-26
> Reporter: Alexander Lehmann
> Priority: Minor
> Attachments: jbehave-skip.zip
>
>
> The examples on the jbehave.org site consistently use "-skip" as meta filter
> to exclude stories marked with @skip true, which doesn't work, however "-skip
> true" works as expected.
> Either the parsing of the filter condition is broken or the examples could be
> changed to use "-skip true".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
