[ https://jira.codehaus.org/browse/JBEHAVE-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=295763#comment-295763 ]
Ivan Verdezoto commented on JBEHAVE-702: ---------------------------------------- Hi, I updated to jbehave-core 3.6 and I am not able to use the pattern variant. All steps had matched perfect before with this configuration, But after I changed some steps (in the steps class) with the variant notation, Jbehave marks thess steps as pending. Do I miss something? Should I change something in the configuration class? Here is a dumb tested example of what I got: - Story file: Scenario: Test Given A x B 10.0 And A y B 1.0 - Steps class: @Given("A {x|y} B $quantity") public void theItemPriceIs(String q) { // ... } - Configuration: MostUsefulConfiguration() .useStoryControls(new StoryControls().doSkipScenariosAfterFailure(false)) .useStoryLoader(new LoadFromClasspath(embeddableClass.getClassLoader())) .usePathCalculator(new RelativePathCalculator()) .useStoryReporterBuilder(reporterBuilder); - Eclipse console output: Processing system properties {} Using controls EmbedderControls[batch=false,skip=false,generateViewAfterStories=true,ignoreFailureInStories=true,ignoreFailureInView=true,verboseFailures=false,verboseFiltering=false,storyTimeoutInSecs=300,threads=1] Using 1 threads (BeforeStories) Running story jbehave/tmp_stories/123.story (jbehave/tmp_stories/123.story) Scenario: Test Given A x B 10.0 (PENDING) And A y B 1.0 (PENDING) @Given("A x B 10.0") @Pending public void givenAXB100(){ // PENDING } @Given("A y B 1.0") @Pending public void givenAYB10(){ // PENDING } . . . > Allow directives to support multiple step pattern variant > --------------------------------------------------------- > > Key: JBEHAVE-702 > URL: https://jira.codehaus.org/browse/JBEHAVE-702 > Project: JBehave > Issue Type: New Feature > Components: Core > Affects Versions: 3.5.4 > Reporter: Daniel Schneller > Assignee: Mauro Talevi > Labels: i18n, wish > Fix For: 3.6 > > Attachments: jbehave-702-1.zip, Steps.java, Steps.java > > > To get more natural German story texts, it would be very helpful if the > Steps.listCandidates() method could be amended. > This would allow for automatically generating slight variations of the texts > without having to specify them all as aliases. Currently I am doing this: > @Then("soll foo bar with $xyz") > @Aliases(values = { > "foo bar with $xyz", > "soll foo bar: $xyz", > "foo bar: $xyz" }) > The word "soll" is made optional this way. The reasoning behind this is that > when using "And" it is more natural to write > Then soll something else > And foo bar with $xyz > instead of > Then soll something else > And soll foo bar with $xyz > It would be very nice to not have define aliases for all these variants, > because it makes the code harder to maintain. Instead, I though I'd add this > dynamically, the same way annotated Aliases are, but it seems this > functionality would require providing a new subclass of > org.jbehave.core.steps.Steps which I cannot see how to do. > I suggest a change like this: > 1) In org.jbehave.core.steps.Steps add another call in listCandidates() after > each of the addCandidatesFromAliases(...) like > addCustomDerivedCandidates(...) with the same signature and a protected empty > default implementation. > 2) Allow configuration to specify a custom subclass of > org.jbehave.core.steps.Steps. In there custom additions to the candidates > list could be made, like the one I described. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email