Thanks for submitting, @KrisSterckx! Overall, looks good! A couple of comments/question that relate to multiple places:
* A few domain model classes are made `final`. Is this required by the code in some way? Otherwise, could you explain the reasoning? * Add Javadoc `@see ...` tags to link related interface methods? * Some interface methods use have `XYZOptions...` as the last parameter. Is the options parameter intended to be optional or mandatory there? * Could you add descriptive messages to `assertTrue(...)` and `assertFalse(...)` tests? With a message, it's much easier to figure out what went wrong when looking at DEV@cloud or BuildHive. * In general, jclouds is trying to use MockWebServer tests rather than expect tests, because a real web server uncovers a couple of things that the expect tests have not caught. Not that these tests need to be changed now, but just FYI... --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/47#issuecomment-28137688
