* Wrap getOrderTemplate in VirtualGuestToNodeMetadata.getImage with try/catch
* Address comments from @nacx and @demobox:
- remove the fields of the custom SoftLayerOrderItemDuplicateException and
propagate the HttpResponseException
- use of order = null instead of return null
- extend RuntimeException instead IllegalStateException in
SoftLayerOrderItemDuplicateException
Conflicts solved:
providers/softlayer/src/main/java/org/jclouds/softlayer/compute/functions/VirtualGuestToNodeMetadata.java
You can merge this Pull Request by running:
git pull https://github.com/andreaturli/jclouds master
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/200
-- Commit Summary --
* JCLOUDS-373: Fix VirtualGuestToNodeMetadata when server returns
SoftLayer_Exception_Order_Item_Duplicate
-- File Changes --
M
providers/softlayer/src/main/java/org/jclouds/softlayer/compute/functions/VirtualGuestToNodeMetadata.java
(25)
A
providers/softlayer/src/main/java/org/jclouds/softlayer/exceptions/SoftLayerOrderItemDuplicateException.java
(25)
M
providers/softlayer/src/main/java/org/jclouds/softlayer/handlers/SoftLayerErrorHandler.java
(3)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/200.patch
https://github.com/jclouds/jclouds/pull/200.diff
