I completely understand, but it is also important that commits are 
self-contained. Imagine a case where we had to revert, say, the style commit. 
We would leave the pagination feature without the fixes, and no one could 
predict that (it is not a realistic example just no note that not having 
self-contained commits has its implications).

I understand that manual changes are required to have the two clean commits, 
and that might not be a nice work to do, but it is not a crazy amount of work. 
It is very focused at the parser classes, the expect test class, and the 
PaginationCollection and PaginationOptions classes.

In the end what matters is that the commit history of the project is consistent.


---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/35#issuecomment-28406315

Reply via email to