> @@ -16,7 +16,7 @@
> */
> package org.jclouds.softlayer.exceptions;
>
> -public class SoftLayerOrderItemDuplicateException extends RuntimeException {
> +public class SoftLayerOrderItemDuplicateException extends
> IllegalStateException {
Same question as before on this: the [Javadoc for
ISE](http://docs.oracle.com/javase/7/docs/api/java/lang/IllegalStateException.html)
states:
"Signals that a method has been invoked at an illegal or inappropriate time. In
other words, the Java environment or Java application is not in an appropriate
state for the requested operation."
But where this exception is thrown (and caught) in this code, the state of the
"Java environment or Java application" is perfectly OK - it's the _target
server_ that has a problem.
So I don't think this is the appropriate exception type to use here.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/204/files#r7647046
