>           } catch (IllegalArgumentException iae) {
>              // no op
>           }
>        }
>        builder.hostname(from.getName());
>        builder.location(findLocationForResourceInVDC.apply(from.getVDC()));
> -      
> builder.group(nodeNamingConvention.groupInUniqueNameOrNull(from.getName()));
> +      if (groupName.equals("")) {

Can `metadataMap.get("jclouds-group")` return the empty string? If not, how 
about
```
String groupName = null;
...
groupName = metadataMap.get("jclouds-group"); // may be null
...
if (groupName == null) {
  groupName = nodeNamingConvention.groupInUniqueNameOrNull(from.getName());
}
...
```

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/206/files#r7710463

Reply via email to