> +            if ((read = input.read(content)) == -1) {
> +               return null;
> +            }
> +         } catch (IOException e) {
> +            throw Throwables.propagate(e);
> +         }
> +
> +         return createPayload((content.length == read) ? content : 
> Arrays.copyOf(content, read));
> +      }
> +
> +      private Payload createPayload(byte[] content) {
> +         Payload payload = null;
> +
> +         if (content.length > 0) {
> +            payload = new ByteArrayPayload(content);
> +            ContentMetadata cm = 
> metaData.toBuilder().contentLength((long)content.length).contentMD5(null).build();

> Do you think it should be removed?

If it's `null` be default anyway, I don't think it's required here (although we 
probably should verify that it's `null` using a test). If it's **not** `null` 
by default, it would be good to know what value is calculated (?) and whether 
we could use that..?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/192/files#r8179893

Reply via email to