Let's change the tests that use heap size to size their input then re-run the experiment. Also a few months ago I changed some integration tests to use smaller inputs in 0d6ef0607617f9968c9fe1267b6fef48e5d329ab and e27ae6117cc813b8c39f4514908541d839fb461a which might have also improved our memory use. Otherwise we can remove the explicit size.
On Wed, Dec 18, 2013 at 04:08:14PM +0100, Ignasi Barrera wrote: > Yes, removing this it speeds up a bit the tests, and also improves > some tests that perform operations on big files (such as an upload). > I think we could safely remove that (given that neither unit nor live > tests use those options), but I'd prefer to ask first for opinions. > > On 18 December 2013 16:04, Andrew Phillips <[email protected]> wrote: > >> Out of curiosity, Does anyone know why we are explicitly configuring > >> the memory for the "integration" tests [1], but not for the "unit" and > >> "live" tests? > >> > >> Can we just remove that line? > > > > > > Do you have any information on what effect that change with have? Does it > > speed things up? Are there any problems that the line is causing for you > > right now..? > > > > ap -- Andrew Gaul http://gaul.org/
