So I know we're technically able to release with three +1s, but I'm
wondering if it might be a good idea to wait 'til a few more people have
had a chance to review the RC before we actually push. Thoughts?

A.


On Mon, Dec 23, 2013 at 12:48 AM, Ignasi Barrera
<[email protected]>wrote:

> Run the verification script and everything is OK.
>
> * Project builds and all unit tests pass
> * No RAT violations
> * Checksums and signatures match
> * Releaser signature is in place
> * No binaries are present in the distribution
> * LICENSE and NOTICE files are OK (with the chef copyright date thing
> already spotted by Andrew P.)
> * Dependencies were properly downloaded from the staging repository
>
> Run live tests for the following providers:
>
> chef-10: Tests run: 50, Failures: 0, Errors: 0, Skipped: 0
> chef-11: Tests run: 50, Failures: 0, Errors: 0, Skipped: 0
> enterprise-chef: Tests run: 47, Failures: 0, Errors: 0, Skipped: 0
> cloudsigma2-lvs (labs): Tests run: 50, Failures: 0, Errors: 0, Skipped: 0
>
>
> +1 to release it.
>
> Good job Andrew!
>
>
> P.S. In the vote for RC1, the tests failures in the cloudsigma2-lvs
> provider appeared because the public ip and private vlans of the live
> test account had expired. I've purchased a few again and live tests
> are passing now (it would be a nice improvement to throw a
> SkipException if no networking is available instead of failing the
> tests).
>
>
> On 21 December 2013 20:35, Andrew Phillips <[email protected]> wrote:
> >> The update is sufficient, I believe.
> >
> >
> > OK, thanks! In that case:
> >
> > =======================================================================
> > Apache ID: andrewp
> > -----------------------------------------------------------------------
> > [X] +1 Release.
> > [ ] -1 Don't release (see notes).
> > -----------------------------------------------------------------------
> > Checklist (all items optional, mark only those personally verified):
> >
> > [X] Checksums and PGP signatures are valid.
> > [ ] Expanded source archive matches contents of RC tag.
> > [X] Expanded source archive builds and passes tests.
> > [X] LICENSE is present and correct.
> > [X] NOTICE is present and correct, including copyright date.
> > [ ] All files have license headers where appropriate.
> > [X] All dependencies have compatible licenses.
> > [X] No compiled archives bundled in source archive.
> > [X] I follow this project's commits list.
> > -----------------------------------------------------------------------
> > Notes:
> > * Ran 'mvn clean install -Dmaven.javadoc.skip=true', which includes the
> > RAT plugin execution.
> > * Checked for compiled archives by searching for ".jar", ".bin",
> > ".zip" and ".tar.gz" in the expanded source archives
> > * Slight discrepancy in the Chef NOTICE file, but I don't think this
> > should block the release, since 2013 is included in the copyright date
> > in all files
> > * Built the blobstore-basics example for jclouds-examples and ran it
> > successfully against ninefold-storage
> >
> > Thanks for pushing out the new RC, abayer!
> >
> > ap
>

Reply via email to