> + DigitalOceanImageExtension(DigitalOceanApi api,
> + @Named(TIMEOUT_IMAGE_AVAILABLE) Predicate<Integer>
> imageAvailablePredicate,
> + @Named(TIMEOUT_NODE_SUSPENDED) Predicate<Integer>
> nodeStoppedPredicate,
> + Function<org.jclouds.digitalocean.domain.Image, Image>
> imageTransformer) {
> + this.api = Preconditions.checkNotNull(api, "api cannot be null");
> + this.imageAvailablePredicate = checkNotNull(imageAvailablePredicate,
> "imageAvailablePredicate cannot be null");
> + this.nodeStoppedPredicate = checkNotNull(nodeStoppedPredicate,
> "nodeStoppedPredicate cannot be null");
> + this.imageTransformer = checkNotNull(imageTransformer,
> "imageTransformer cannot be null");
> + }
> +
> + @Override
> + public ImageTemplate buildImageTemplateFromNode(String name, String id) {
> + Droplet droplet = null;
> + try {
> + droplet = api.getDropletApi().get(Integer.valueOf(id));
> + } catch (Exception ex) {
That catch should be removed. It was just a guard, before the provider had
properly implemented the error/retry handlers.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/49/files#r9170968
