Thanks Ignasi for the info. I can update the interface for making the Options mandatory and removing the default values for BlockDeviceMapping.0.DeviceName and RootDeviceName
However I was thinking of adding implementation to default the above values, if the options do not have it already. Any suggestions for handling that without actually implementing it ? Rgds Jai On Mon, Mar 10, 2014 at 9:51 AM, Ignasi Barrera <[email protected]> wrote: > Hi Jai, > > There is no implementation. jclouds automatically generates the > requests based on the method's annotations. In this thread [1] you'll > fire more details about how jclouds does that. Also, I'm trying to > write a developer guide covering this stuff this week, so stay tuned > to our wiki. > > Back to the method you want to modify, you should just need to modify > the interface :) > > > Ignasi > > > > [1] http://markmail.org/message/bvkquv6b6cxjkpbv > [2] http://wiki.apache.org/jclouds/ > > On 10 March 2014 17:41, Jai M <[email protected]> wrote: >> Hi Developers, >> >> I am trying to add/modify an implementation for the AMIApi for a >> registerUnixImageBackedByEbsInRegion but cannot find the existing >> implementation class. I am new to Guice even though I a quiet familiar >> with dependency injection (with Spring). I spend the whole day >> yesterday trying to figure it out. Any help in this regard will save >> me some time :) >> >> Rgds >> Jai >> >> On Wed, Mar 5, 2014 at 12:30 PM, Ignasi Barrera >> <[email protected]> wrote: >>> That's fantastic. Thanks for taking care of this Jai! >>> >>> >>> On 5 March 2014 18:43, Jai M <[email protected]> wrote: >>> >>>> Hi Ignasi, >>>> >>>> I agree with your view points. I was also thinking in the same lines >>>> earlier. I have locally tested it by adding a new method which takes the >>>> root device name as a parameter and it works with Amazon too. I will go >>>> ahead and add the new method to configure the root device and send it >>>> across for review. >>>> >>>> >>>> Rgds >>>> >>>> Jai >>>> On Mar 4, 2014 11:41 PM, "Ignasi Barrera" <[email protected]> wrote: >>>> >>>> > Hi Jai, >>>> > >>>> > I would remove the hardcoded value and add a method to the options class >>>> to >>>> > configure it, but since the options is a varargs, it could be ommited and >>>> > the root device undefined. >>>> > >>>> > I think a good approach would be removing the options parameter from the >>>> > existing method and create a new one with the options object not being a >>>> > varargs (making it mandatory). This way you could add the new method to >>>> > configure the root device in the options object (and default to the >>>> current >>>> > one). >>>> > >>>> > This keeps the current behavior but does not allow to pass N option >>>> > parameters, which makes no sense. I think the varargs was there to make >>>> the >>>> > parameter optional, but that's not the right way to do that :) >>>> > >>>> > WDYT? >>>> > >>>> > Thanks for your interest! >>>> > >>>> > You can find how to contribute here [1]. Feel free to join our IRC >>>> channel >>>> > [2] to ask anything you need! >>>> > >>>> > Ignasi >>>> > >>>> > [1] http://wiki.apache.org/jclouds/How%20to%20Contribute >>>> > [2] http://jclouds.apache.org/community/ >>>> > El 04/03/2014 23:32, "Jai M" <[email protected]> escribió: >>>> > >>>> > > Hi, >>>> > > >>>> > > I would like to contribute with bug fixes to the jclouds group. I >>>> > > would like to know the procedure for getting started. Any pointers >>>> > > would be useful. I would like to work on the following >>>> > > >>>> > > 1. registerUnixImageBackedByEbsInRegion, option to specify a root >>>> > > device name. Right now it is being hardcoded to /dev/sda1 in the >>>> > > interface as form parameters. >>>> > > 2. AWS gov cloud is not working currently. I am trying to get it >>>> > > working for our project and eventually contribute it back to the >>>> > > jclouds code base. >>>> > > >>>> > > >>>> > > Rgds >>>> > > Jai >>>> > > >>>> > >>>>
