That would be fine by me. What I wanted to highlight is that having a Set as a parameter may cause the impression that N ips will be allocated. At least it is the impression that Set would give to me :)
If the javadoc and name of the method properly reflect the behavior, then it is ok to me. El 30/06/2014 19:09, "Everett Toews" <everett.to...@rackspace.com> escribió: > On Jun 30, 2014, at 2:35 AM, Ignasi Barrera <n...@apache.org> wrote: > > > Regarding the proposed implementation, you'll be passing a Set but > > allocating only one Ip. Couldn't this cause confusion to users? Also, the > > Ip in the set that will actually be allocated is not predictable. > > Unless I’m mistaken, I believe the intention is to allocate 1 IP address > from any the Set of IP address pools passed in. > > It’s a way for the user to express that they need an IP address from some > pool. Because it’s a Set and the iterator order is guaranteed, I think the > Javadoc on the param for floatingIpPoolNames would need to be something like > > “The IP Address is allocated from any one of the specified pools.” > > Or something like that. > > Everett
