Here's the feedback which I think says "go" anyway. Let's please prioritize ending the madness of the terrible ConcreteBuilder crap in the next version or two so folks don't accidentally emulate it then feel torn being asked to undo it.
--- There is no problem closing the PR and openning a new one on master. Its not life and death as far as these api goes. Plus you guys are ripping me a new one on the code review lol :D Although regarding the extention api I think that making the parameters nulleble will make the code simpler and easier to manage (consider muti types of extention on one api you wont see the end of it regarding enharetance classes for extentions (i am talking about PR 562... ) On Wed, Oct 8, 2014 at 10:56 AM, Andrew Phillips <aphill...@qrmedia.com> wrote: >> Yes he is :) Unfortunately his email are being rejected on spam score, >> so I am channeling Inbar. > > > I see 561 and 559 [1, 2] are in - were those the two you were referring to? > If so, time to pull the levers! > > ap > > [1] https://github.com/jclouds/jclouds/pull/561 > [2] https://github.com/jclouds/jclouds/pull/559
