Hi, Bhathiya Thanks for keeping an eye on things. Probably best to note suggestions in the jira as they can be easier followed there.
Main goals are to clean it up so that it can be promoted out of labs. I've made some notes inline regardless. Hope to see you around! On Tue, Nov 4, 2014 at 9:58 AM, Bhathiya Supun <hsbath...@gmail.com> wrote: > I see Google Cloud Storage implementation > https://issues.apache.org/jira/browse/JCLOUDS-458 is reopened and some > changes going on. I would like to know whether there is a way I can help? Yep. try and keep tests passing, look at pull reviews, etc. > BTW I have few suggestions related to GCS > > 1 - CRC32C > > Google Cloud Storage used Guava-18 for CRC32c implemetation. If we are not > planning to upgrade jclouds guava version, we can use google cloud platform > code crc32c implemetation [2] in our code We don't need to include guava or google's crc32c implementation as long as we expose a field which users can set. For example, an insert option. How the user creates the crc32c is up to them. Only place we want to employ the google crc32 impl is in the test tree (please only in the test tree). Feel free to give that a go. ex. make a function that does a crc32c and use that in the test. > > As of GCS docs CRC32C is preffered over MD5 > "Google recommends that customers use CRC32C for all cases, as described in > the Validation section below. Customers that prefer MD5 can use that hash, > but that hash is not supported for composite objects or range GETs"[1] BlobStore uses MD5 regardless, so there will still be a use case for that field when folks use jclouds portably. > > 2 - Object Change Notification Support > > This feature is already implemented without testing.Testing it requires a > Https application url [3] That may not be practical to test, unless you can figure out a public webhook to send the notifications to. > > > [1] https://cloud.google.com/storage/docs/hashes-etags#_CRC32C > > [2] https://github.com/GoogleCloudPlatform/crc32c- > java/blob/master/src/com/google/cloud/Crc32c.java > > [3] https://cloud.google.com/storage/docs/object-change-notification
