Take i to account we have the compat build in Jenkins that already tests all versions. Can we rely on our unit tests (and the compat build?) To be confident the changes are ok?
On Mar 31, 2017 7:59 AM, "Andrew Gaul" <g...@apache.org> wrote: > On Fri, Mar 31, 2017 at 01:19:22AM -0400, Andrew Phillips wrote: > > >How can we move forward here? > > > > Do we have any idea how much work would be needed to continue to > > support users with Guava 16 and 17 if we moved to Guava 18 as the > > default? Assuming that's even technically possible, of course. > > > > That would still leave us with hacks in the codebase, but those > > would hopefully be temporary and could be phased out if and when > > it's deemed acceptable to drop support for Guava 16 and then 17. > > Unfortunately jclouds has many call sites for Objects/MoreObjects. You > can fix many of them with: > > find -name \*.java | xargs sed -i 's/^import > com.google.common.base.Objects/import > com.google.common.base.MoreObjects/' > find -name \*.java | xargs sed -i 's/^import static > com.google.common.base.Objects.toStringHelper/import > static com.google.common.base.MoreObjects.toStringHelper/' > find -name \*.java | xargs sed -i 's/\<Objects.toStringHelper/ > MoreObjects.toStringHelper/' > find -name \*.java | xargs sed -i 's/sameThreadExecutor/directExecutor/' > > But then you need to fix up some of the Objects.equal call sites. > Unfortunately this may require manual attention unless someone figures > out how to use Refaster. > > -- > Andrew Gaul > http://gaul.org/ >
