I followed the same approach than the other methods in this class. Should we better change them all to throw skip exceptions?
On Monday, 23 October 2017, Andrew Gaul <notificati...@github.com> wrote: > *@gaul* requested changes on this pull request. > ------------------------------ > > In apis/filesystem/src/test/java/org/jclouds/filesystem/integration/ > FilesystemBlobIntegrationTest.java > <https://github.com/jclouds/jclouds/pull/1150#discussion_r146391479>: > > > @@ -89,6 +91,15 @@ protected void checkUserMetadata(Map<String, String> > > userMetadata1, Map<String, > } > } > > + /* Java on OS X does not support extended attributes, which the > filesystem backend > + * uses to implement storage tiers */ > + @Override > + protected void testPutBlobTierHelper(Tier tier, PutOptions options) > throws Exception { > + if (!isMacOSX()) { > > Instead could you flag this as skipped via: > > if (isMacOSX()) { > throw new SkipException("Extended attributes not supported on Mac OS X"); > } > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/jclouds/jclouds/pull/1150#pullrequestreview-71327087>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AEN2-uNCnZifF66f10L_NRqcc1pnFWFrks5svP2YgaJpZM4QDduN> > . >
