Changing those files should be enough. On Wed, Nov 28, 2018, 04:39 kazim.a...@gmail.com <kazim.a...@gmail.com wrote:
> Hi Ignasi, > > Yes I would want to add these missing cd5 & md5 Instance Types, I am not > sure if I got to do any more changes that its being done in JCLOUDS-1387 as > so far I couldn't see any instance-types that JClouds supports that have > NVMe as the Instance Storage. Do you know if any other change is required > than just updating following below to support NVMe Storage? > > 1. > apis/ec2/src/main/java/org/jclouds/ec2/compute/domain/EC2HardwareBuilder.java > 2. apis/ec2/src/main/java/org/jclouds/ec2/domain/InstanceType.java > 3. > providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/compute/suppliers/AWSEC2HardwareSupplier.java > > On 2018/11/21 23:13:58, Ignasi Barrera <n...@apache.org> wrote: > > HI Kazim, > > > > The best way to move forward and get things done is... just go ahead and > do > > them :) > > > > If you look at JCLOUDS-1387 and the pull request that fixes it, you'll > see > > that adding the missing instance types is quite easy. Would you want to > add > > them and send a pull request? (We'll be happy to help and assist) That > > would be very much appreciated and definitely the fastest way to get that > > fixed. > > > > > > Regards, > > > > I. > > > > > > On Wed, 21 Nov 2018 at 22:57, Kazim Raza <kr...@primaticsfinancial.com> > > wrote: > > > > > Hi Devs, > > > > > > > > > There is a recent enhancement being done (JCLOUDS-1387< > > > https://issues.apache.org/jira/browse/JCLOUDS-1387> ) to support C5 & > M5 > > > AWS instance types that do not supports the complete series, If you > check > > > the whole list here at: AWS > https://aws.amazon.com/ec2/instance-types/c5/ > > > > > > JClouds version 2.1.1 is missing AWS InstanceTypes c5d.large to > > > c5d.18xlarge. > > > > > > > > > Can anyone of you please let me know the way to move forward? We > wanted to > > > use one of the C5d / M5d AWS Instance Types but couldn't be able to > > > provision it using JCLOUDS. I have cut a JIRA ticket on JCLOUDS here > as: > > > https://issues.apache.org/jira/browse/JCLOUDS-1467 > > > > > > > > > Awaiting your response on that matter. > > > > > > > > > Thanks, > > > > > > Kazim > > > > > > > > >
