Hello, Thanks for your comments and improvement suggestions. It is now fixed. Best regards, Alexandra
On 2019/01/30 21:02:49, Andrew Gaul <g...@apache.org> wrote: > If you add debug statements to authSAS does it return true? Also the > logic seems wonky here; see my "huh?" comment. > > On Tue, Jan 29, 2019 at 03:03:51PM -0000, aliaksandra.kharus...@gmail.com > wrote: > > Hello Ignasi, > > > > Sorry for such a late reply. > > > > I have finally pushed my code to my branch here: > > https://github.com/ahorusz/jclouds. > > I have not yet opened a pull request. > > > > I still wonder, why the AzureBlobRequestSigner.sign() method is never > > called. > > > > Could you please take a quick look at my code before I trigger the pull > > request? > > > > Thanks a lot for inviting me to slack! > > > > Best regards, > > Aliaksandra > > > > > > On 2019/01/18 14:58:00, Ignasi Barrera <n...@apache.org> wrote: > > > Hi! > > > > > > Thanks for being working on this and sharing your issues. Do you have your > > > changes in a GitHub branch or somewhere we could have a look, to try find > > > where the problem can be? > > > > > > > > > Thanks! > > > > > > I. > > > > > > > > > > > > On Fri, 11 Jan 2019 at 15:54, aliaksandra.kharus...@gmail.com < > > > aliaksandra.kharus...@gmail.com> wrote: > > > > > > > Hello everyone, > > > > > > > > I am working on the "Support for SAS token based Authentication for > > > > Azure > > > > Blob Storage" JIRA item. > > > > It is my first open source contribution, so I apologise for any silly > > > > questions I may ask. > > > > > > > > I have been studying the code as well as experimenting with it for the > > > > last couple of weeks, and there are still some extremely unclear topics. > > > > Unfortunately, I could not find any advanced documentation on the > > > > Internet. > > > > I am not sure if this is the right place to ask such questions. > > > > > > > > I have one specific question regarding AzureBlobRequestSigner class. > > > > > > > > While executing this line > > > > HttpRequest req = context.getSigner().signGetBlob(containerName, blob); > > > > > > > > I am getting something like this: GET > > > > https://identity.blob.core.windows.net/containername/blobname?sp=rwdl&st=2019-01-10T12:16:54Z&se=2019-12-31T13:16:00Z&sv=2018-03-28&sig=KSHG5sJSlMla4TtjYWcUSxFZQt%2BuvvrHhGHFCYvwV6U%3D&sr=b > > > > HTTP/1.1 (I modified some values here in this SAS for security reasons). > > > > > > > > However, when I am doing this: > > > > AzureBlobClient azureBlobClient = > > > > context.unwrapApi(AzureBlobClient.class); > > > > AzureBlob blob = azureBlobClient.getBlob(containerName, blobName); > > > > > > > > the AzureBlobRequestSigner.sign() seems not to be reached. > > > > I suspect there is something broken in between, because when I rollback > > > > to > > > > original code and try doing the same with SharedKey, everything works > > > > smoothly. > > > > > > > > I would really appreciate if you could point me in the right direction > > > > and > > > > give any clues on how to solve this problem. > > > > > > > > Thanks a lot in advance, > > > > Best regards, > > > > Alexandra > > > > > > > > > -- > Andrew Gaul > http://gaul.org/ >
