Hello,
I am looking at https://issues.apache.org/jira/browse/JCLOUDS-1491, and
specifically the use of deprecated (and now removed) guava APIs in code
used to support Azure cloud storage.
If I understand correctly, updating the guava version is a challenge due to
dependencies on Apache Karaf.
However, CharMatcher.JAVA_LETTER_OR_DIGIT has been removed in guava 26.0,
and CharMatcher.javaLetterOrDigit() should be used instead since guava
19.0. Note that CharMatcher.javaLetterOrDigit() was immediately deprecated
in Guava 26.0, and java.lang.Character.isLetterOrDigit(int) should be used
instead.
So it looks possible to get rid of the dependency on
CharMatcher.JAVA_LETTER_OR_DIGIT with the fix at the bottom of this email
(I think I may not need the check on the string emptiness, but I am not
100% sure):
What do you think?
Thanks,
Jean-Noël
$ git diff
diff --git
a/core/src/main/java/org/jclouds/predicates/validators/DnsNameValidator.java
b/core/src/main/java/org/jclouds/predicates/validators/DnsNameValidator.java
index 1102cb8435..fa14b1d510 100644
---
a/core/src/main/java/org/jclouds/predicates/validators/DnsNameValidator.java
+++
b/core/src/main/java/org/jclouds/predicates/validators/DnsNameValidator.java
@@ -46,11 +46,10 @@ public class DnsNameValidator extends Validator<String>
{
}
public void validate(String name) {
-
if (name == null || name.length() < min || name.length() > max)
throw exception(name, "Can't be null or empty. Length must be " +
min + " to " + max
+ " symbols.");
- if (CharMatcher.JAVA_LETTER_OR_DIGIT.indexIn(name) != 0)
+ if (!name.isEmpty() && Characters.isLetterOrDigit(name.charAt(0)))
throw exception(name, "Should start with letter/number");
if (!name.toLowerCase().equals(name))
throw exception(name, "Should be only lowercase");
However, it looks like it is possible to get rid of the use of
CharMatcher.JAVA_LETTER_OR_DIGIT .
https://bugster.forgerock.org/jira/browse/OPENDJ-7166?focusedCommentId=190259&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-190259
