Well, I agree. This is obviously something we should get a mentor to look at once we have a wiki page to be sure we're going to make all lawyercats happy.
On Fri, May 24, 2013 at 4:18 PM, Ignasi <[email protected]> wrote: > Also we should recommend using "git format-patch" instead of "git > diff" when attaching patches to JIRAs. This way the patch includes the > author's name and email, and applying it with "git am" will preserve > both. > > I'll make sure to add that in the wiki, if you agree. > > > > On 25 May 2013 00:57, Andrew Gaul <[email protected]> wrote: > > For @timuralp recent commit, I added his GitHub repo as a remote, > > cherry-picked the branch, then pushed. This required a little more work > > but I think contributors like seeing their names in the clouds. > > > > On Fri, May 24, 2013 at 03:51:06PM -0700, Andrew Bayer wrote: > >> Ideally, yes - but we need to document what the preferred procedure is > for > >> non-committer pull requests (which we should do, since we now have a > wiki!) > >> so I'm personally not particularly chuffed at this in the meantime. > >> > >> A. > >> > >> On Fri, May 24, 2013 at 3:48 PM, Matt Stephenson <[email protected] > >wrote: > >> > >> > Shouldn't the author be Tang Yong instead of Andrew Phillips? > >> > > >> > > >> > On Fri, May 24, 2013 at 2:20 PM, <[email protected]> wrote: > >> > > >> >> Updated Branches: > >> >> refs/heads/1.6.x a67afcb21 -> a0232b09b > >> >> > >> >> > >> >> JCLOUDS-68: Correcting Keystone feature description > >> >> Submitted by Tang Yong > >> >> > >> >> > >> >> Project: > >> >> http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/repo > >> >> Commit: > >> >> > http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/commit/a0232b09 > >> >> Tree: > >> >> > http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/tree/a0232b09 > >> >> Diff: > >> >> > http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/diff/a0232b09 > >> >> > >> >> Branch: refs/heads/1.6.x > >> >> Commit: a0232b09b5d2453620da4bb533a86136e0867b1a > >> >> Parents: a67afcb > >> >> Author: Andrew Phillips <[email protected]> > >> >> Authored: Thu May 23 18:30:24 2013 +0200 > >> >> Committer: Andrew Phillips <[email protected]> > >> >> Committed: Fri May 24 17:20:04 2013 -0400 > >> >> > >> >> > ---------------------------------------------------------------------- > >> >> feature/src/main/resources/feature.xml | 2 +- > >> >> 1 files changed, 1 insertions(+), 1 deletions(-) > >> >> > ---------------------------------------------------------------------- > >> >> > >> >> > >> >> > >> >> > http://git-wip-us.apache.org/repos/asf/incubator-jclouds-karaf/blob/a0232b09/feature/src/main/resources/feature.xml > >> >> > ---------------------------------------------------------------------- > >> >> diff --git a/feature/src/main/resources/feature.xml > >> >> b/feature/src/main/resources/feature.xml > >> >> index 4a29491..d32d340 100644 > >> >> --- a/feature/src/main/resources/feature.xml > >> >> +++ b/feature/src/main/resources/feature.xml > >> >> @@ -92,7 +92,7 @@ limitations under the License. > >> >> > >> >> > <bundle>mvn:org.apache.jclouds.api/openstack-nova/${jclouds.version}</bundle> > >> >> </feature> > >> >> > >> >> - <feature name='jclouds-api-openstack-keystone' > description='JClouds > >> >> - API - OpenStack Nova' version='${project.version}' > resolver='(obr)'> > >> >> + <feature name='jclouds-api-openstack-keystone' > description='JClouds > >> >> - API - OpenStack Keystone' version='${project.version}' > resolver='(obr)'> > >> >> <feature version='${project.version}'>jclouds</feature> > >> >> > >> >> > > <bundle>mvn:org.apache.jclouds.api/openstack-keystone/${jclouds.version}</bundle> > >> >> </feature> > >> >> > >> >> > >> > > > > > -- > > Andrew Gaul > > http://gaul.org/ >
