Hi David,

This was discussed here [1] and addressed here [2]. Those files are
script fragments that are composed to build complex scripts. All those
script files in src/test/resources have the corresponding script
fragment in src/main/resources/functions, and all those fragments have
the appropriate headers.

However, as said in the thread, we are removing the license headers of
the fragments at runtime when loading the files, so the final composed
script has only one header at the top. That means that in runtime,
single fragments won't have a license header, and that is the reason
why files in src/test/resources don't have them: to properly assert in
unit tests that the license "remove" when loading fragments actually
works and we end up with a composed script with only one header at the
top.


Hope this makes sense,


Ignasi

[1] http://markmail.org/message/emu4axdy3qzqxjto
[2] https://issues.apache.org/jira/browse/JCLOUDS-67

On 13 June 2013 06:51, David Nalley <[email protected]> wrote:
> On Wed, Jun 12, 2013 at 9:35 PM, Andrew Bayer <[email protected]> wrote:
>> Hello,
>>
>> This is the third release candidate for Apache jclouds 1.6.1-incubating,
>> the first jclouds release at Apache.
>>
>> This is a PPMC vote - if this passes, we'll move it onward to an IPMC vote.
>>
>> It fixes the following issues:
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12324412&styleName=Html&projectId=12314430
>>
>> *** Please download, test and vote by Saturday, June 15th, 7pm PDT.
>>
>> Note that we are voting upon the source (tag), binaries are provided for
>> convenience.
>>
>> Source and binary files:
>> http://people.apache.org/~abayer/jclouds-1.6.1-incubating-candidate-3
>>
>> Maven staging repo:
>> https://repository.apache.org/content/repositories/orgapachejclouds-016
>>
>> The tags to be voted upon:
>> - jclouds -
>> https://git-wip-us.apache.org/repos/asf?p=incubator-jclouds.git;a=tag;h=8ed5571b0ecf7d79c64bc16642264684882f0311
>> - jclouds-labs -
>> https://git-wip-us.apache.org/repos/asf?p=incubator-jclouds-labs.git;a=tag;h=54b084e474e0c22b539ed7cce0b0ebbc82b310cb
>> - jclouds-chef -
>> https://git-wip-us.apache.org/repos/asf?p=incubator-jclouds-chef.git;a=tag;h=4adced11f4e74513c06023d6b3cde0642fd4017f
>> - jclouds-karaf -
>> https://git-wip-us.apache.org/repos/asf?p=incubator-jclouds-karaf.git;a=tag;h=9e1f0d14285c8edeb35499f313aa7dbfab4a86f6
>> - jclouds-cli -
>> https://git-wip-us.apache.org/repos/asf?p=incubator-jclouds-cli.git;a=tag;h=2e3575f56de2bf67469782d94d72ce8e621ddda5
>>
>> jclouds KEYS file containing PGP keys we use to sign the release:
>> http://www.apache.org/dist/incubator/jclouds/KEYS
>>
>> [ ] +1
>> [ ] 0
>> [ ] -1 (explain why)
>>
>> A.
>
> Overall looking good -
>
> Did we talk about the files in scriptbuilder/src/test/resources in
> jclouds tarball itself?
>
> I can't seem to find a record of it. Can someone explain why we don't
> have license headers on those files.
>
> --David

Reply via email to