> @Provides
> @Singleton
> @Storage
> - protected Supplier<URI>
> provideStorageUrl(RegionIdToURISupplier.Factory factory, @ApiVersion String
> apiVersion) {
> - return
> getLastValueInMap(factory.createForApiTypeAndVersion(ServiceType.OBJECT_STORE,
> apiVersion));
> + protected Supplier<URI>
> provideStorageUrl(RegionIdToURISupplier.Factory factory,
> + @ApiVersion String apiVersion,
> + @Named(LocationConstants.PROPERTY_REGION) String region) {
> I don't know how we can use a null value. What are your thoughts?
Thanks for explaining that we're not really expecting any null value here - I
was just led to that conclusion by the `isNullOrEmpty` check below. If `null`
is _not_ expected here, perhaps just check for an empty string below, or add a
comment that it will _not_ be `null`?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/31/files#r4863787
