I think in this case it makes more sense to have the separate commits. This way 
the issue will have a patch that only addresses the issue itself.
Regarding tests, there are already the 
[VirtualMachineUndeployMonitorTest](https://github.com/jclouds/jclouds-labs/blob/master/abiquo/src/test/java/org/jclouds/abiquo/monitor/functions/VirtualMachineUndeployMonitorTest.java)
 and the 
[AsyncMonitorTest](https://github.com/jclouds/jclouds-labs/blob/master/abiquo/src/test/java/org/jclouds/abiquo/internal/AsyncMonitorTest.java)
 test classes that take care of verifying that all monitoring stuff is working 
properly, so given that the compute service live tests will already test this 
method I think there is no need to add here specific tests for the timeouts.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/11#issuecomment-20727840

Reply via email to