> @@ -247,7 +247,7 @@ public void testReserveWhenResponseIs4xx() throws 
> Exception {
>              .addHeader("Accept", MediaType.APPLICATION_JSON)
>              .addHeader("X-Auth-Token", authToken).build();
>  
> -      HttpResponse createResponse = HttpResponse.builder().statusCode(401)
> +      HttpResponse createResponse = HttpResponse.builder().statusCode(403)

As I understand from 
[JCLOUDS-178](https://issues.apache.org/jira/browse/JCLOUDS-178), a 401 can 
only be returned when the token has expired, so once it is renewed the 401 
should no longer appear, at least in a reasonable amount of time. Since expect 
tests are just mocks, that "re-authentication" never happened and that produced 
the loop. I understand that won't be the case in live tests (it should be good 
to have a live test for this, if possible).

Anyway, I merged this because it literally made the build take forever, and 
that blocked not only the build but all subsequent PRs. Fix the build, then fix 
the feature (if needed).

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/16/files#r5135321

Reply via email to