> @@ -33,8 +33,8 @@
> @Singleton
> public class BlockIdValidator extends Validator<String> {
> @Override
> - public void validate(@Nullable String s) throws IllegalArgumentException {
> - if (s.length() > 64)
> + public void validate(String s) throws IllegalArgumentException {
Hm, if we remove the annotation wouldn't the assumption be (as elsewhere in
jclouds) that `s` is **not** `null`, which would make the `null` check seem
superfluous? I think we should either have the annotation and the null check or
drop the annotation, assume that `s` cannot be null and drop the null check.
If the latter assumption is incorrect, I'd vote for the annotation and the null
check.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/66/files#r5156816
