> @@ -44,6 +46,11 @@
>   */
>  @Test(groups = "api", testName = "VirtualMachineLiveApiTest")
>  public class VirtualMachineLiveApiTest extends BaseAbiquoApiLiveApiTest {
> +   public void testListAllVirtualMachines() {
> +      Iterable<VirtualMachine> vms = 
> env.context.getCloudService().listVirtualMachines();
> +      assertTrue(size(vms) > 1);

I agree it is a loose condition. The live tests could be executed on a dirty 
environment, where the user already had deployed vms, so the number of returned 
vms is not predictable here. The test's setup creates one, though, so I'll add 
an assertion to check that the created vm is in the list (although as long as 
the list method is able to return more than one, we can assume it is working).

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/14/files#r5160271

Reply via email to