> @@ -133,6 +133,12 @@ HttpRequest replaceSecurityTokenHeader(HttpRequest 
> request, SessionCredentials c
>     }
>  
>     HttpRequest replaceAuthorizationHeader(HttpRequest request, String 
> signature) {
> +      // Only add the Authorization header if the query string doesn't 
> already contain
> +      // the 'Signature' parameter, otherwise S3 will fail the request 
> complaining about
> +      // duplicate authentication methods.
> +      if (request.getEndpoint().toString().contains("Signature")) {

Is this a fix to `replaceAuthorizationHeader` that's unrelated to the feature 
addition (i.e. should be made anyway) or is this part of the new functionality?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/71/files#r5335992

Reply via email to