> +
> + }
> +
> + /**
> + * Deprecation information for an image
> + */
> + public static class Deprecated {
> + private final Optional<String> state;
> + private final Optional<URI> replacement;
> + private final Optional<String> deprecated;
> + private final Optional<String> obsolete;
> + private final Optional<String> deleted;
> +
> + @ConstructorProperties({"state", "replacement", "deprecated",
> "obsolete", "deleted"})
> + public Deprecated(String state, URI replacement, String deprecated,
> String obsolete,
> + String deleted) {
I think `Optional`s are fine, but the constructor args aren't `Optional`s and I
haven't seen that in the code too often, but might be looking at a skewed
sample. I'm just wondering whether a user looking at the Javadoc or an IDE here
would know that all of the properties are allowed to be `null`.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/16/files#r5379602