> @@ -321,6 +341,24 @@ public CreateServerOptions 
> securityGroupNames(Iterable<String> securityGroupName
>        return this;
>     }
>     
> +   /**
> +    * 
> +    * @see #getNetworks
> +    */
> +   public CreateServerOptions networks(String... networks) {
> +      return networks(ImmutableSet.copyOf(checkNotNull(networks, "network 
> should not be empty")));

The "standard" jclouds pattern would be `checkNotNull(networks, "networks")`, 
but in this case it's not doing the expected thing since a varargs argument 
cannot be `null`, it will be an empty array instead.

If we want to enforce this check, it probably should be:
```
checkArgument(networks.length > 0, "networks should not be empty");
return networks(ImmutableSet.copyOf(networks));
```

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/72/files#r5386491

Reply via email to