> @@ -178,6 +210,15 @@ protected void checkFirewallRule(FirewallRule rule) {
> assert rule.getProtocol() != null;
> }
>
> + protected void checkEgressFirewallRule(FirewallRule rule) {
> + assertEquals(rule,
> + client.getFirewallApi().getEgressFirewallRule(rule.getId()));
Is this not enough? The rest seems like a "validity check" of some sort -
should that perhaps go in `FirewallRule` itself? Should it even be _possible_
to create a FirewallRule that violates the checks that follow?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/69/files#r5401181
