> @@ -133,14 +132,7 @@ HttpRequest replaceSecurityTokenHeader(HttpRequest
> request, SessionCredentials c
> return request.toBuilder().replaceHeader("x-amz-security-token",
> current.getSessionToken()).build();
> }
>
> - HttpRequest replaceAuthorizationHeader(HttpRequest request, String
> signature) {
> - // Only add the Authorization header if the query string doesn't
> already contain
> - // the 'Signature' parameter, otherwise S3 will fail the request
> complaining about
> - // duplicate authentication methods. The 'Signature' parameter will be
> added for signed URLs
> - // with expiration.
> - if
> (Queries.queryParser().apply(request.getEndpoint().getQuery()).containsKey("Signature"))
> {
> - return request;
> - }
As per IRC chat, this logic does not belong here because now the API suddenly
knows about some feature supported (for now) by only one specific provider. The
special-case logic should live in the provider.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/74/files#r5408090
