@demobox I'm happy to provide evidence if there are specific concerns. Here's a
simple experiment for you: construct a `HttpRequest` and specify an endpoint
such as `http://localhost/foo?bar+baz`. Now invoke this `HttpRequest` with an
injected `HttpClient` (which by default will run via
`JavaUrlHttpCommandExecutorService`). Now check your web server logs and you'll
see that the URL that is actually requested is `http://localhost/foo?bar baz`.
That said, IMO in this case the code speaks for itself. Here's
`Strings2.urlEncode`:
```
public static String urlEncode(String in, Iterable<Character> skipEncode) {
if (isUrlEncoded(in))
return in;
...
```
If you saw that and were writing a corresponding `urlDecode`, would you not
check for `!isUrlEncoded`?
Anyways, I'll let you and @andrewgaul figure out what to do with this and the
other patches. Feel free to revert if you judge that to be the best course of
action. @andrewgaul I'm curious though, why do you think this patch makes the
release DOA?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/82#issuecomment-21988085
