> +      }
> +
> +      public UserOptions build() {
> +         UserOptions options = new UserOptions();
> +
> +         if (page != null) {
> +            options.queryParameters.put("page", String.valueOf(page));
> +         }
> +
> +         if (results != null) {
> +            options.queryParameters.put("numResults", 
> String.valueOf(results));
> +         }
> +
> +         return addFilterOptions(options);
> +      }
> +   }

That's a nice trick. But I think that `page` and `startWith` are semantically 
different: I understand the first one as the page number, and the other as the 
first item that must appear in the requested page. Should I calculate the value 
of  `page` based on the values of `startWith` and `limit`? What if `limit`is 
not defined? Is there any default value for it?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/22/files#r5704374

Reply via email to