Implemented the PagedIterable in Abiquo: * Refactored all the domain objects to return Iterables instead of Lists, to allow a more flexible approach when using the PagedIterable. * Added a generic PaginatedCollection that knows how to advance any paginated collection. * Changed all methods from the Abiquo APIs that allow pagination to return the corresponding PagedIterables and PaginatedCollections. * Added Expect tests for every paginated resource. You can merge this Pull Request by running:
git pull https://github.com/nacx/jclouds-labs 198-pagination Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs/pull/24 -- Commit Summary -- * JCLOUDS-198: Implemented the PagedIterable in Abiquo -- File Changes -- M abiquo/src/main/java/org/jclouds/abiquo/compute/functions/VirtualMachineToNodeMetadata.java (4) M abiquo/src/main/java/org/jclouds/abiquo/config/AbiquoHttpApiModule.java (9) M abiquo/src/main/java/org/jclouds/abiquo/domain/DomainWithTasksWrapper.java (5) M abiquo/src/main/java/org/jclouds/abiquo/domain/DomainWrapper.java (18) A abiquo/src/main/java/org/jclouds/abiquo/domain/PaginatedCollection.java (160) M abiquo/src/main/java/org/jclouds/abiquo/domain/cloud/VirtualAppliance.java (15) M abiquo/src/main/java/org/jclouds/abiquo/domain/cloud/VirtualDatacenter.java (73) M abiquo/src/main/java/org/jclouds/abiquo/domain/cloud/VirtualMachine.java (6) M abiquo/src/main/java/org/jclouds/abiquo/domain/cloud/VirtualMachineTemplate.java (5) M abiquo/src/main/java/org/jclouds/abiquo/domain/enterprise/Enterprise.java (37) M abiquo/src/main/java/org/jclouds/abiquo/domain/enterprise/Role.java (3) M abiquo/src/main/java/org/jclouds/abiquo/domain/enterprise/TemplateDefinitionList.java (9) M abiquo/src/main/java/org/jclouds/abiquo/domain/enterprise/User.java (7) M abiquo/src/main/java/org/jclouds/abiquo/domain/enterprise/options/EnterpriseOptions.java (56) M abiquo/src/main/java/org/jclouds/abiquo/domain/infrastructure/Datacenter.java (41) M abiquo/src/main/java/org/jclouds/abiquo/domain/infrastructure/Machine.java (15) M abiquo/src/main/java/org/jclouds/abiquo/domain/infrastructure/Rack.java (4) M abiquo/src/main/java/org/jclouds/abiquo/domain/infrastructure/StorageDevice.java (10) M abiquo/src/main/java/org/jclouds/abiquo/domain/infrastructure/Tier.java (4) M abiquo/src/main/java/org/jclouds/abiquo/domain/network/ExternalNetwork.java (23) M abiquo/src/main/java/org/jclouds/abiquo/domain/network/Network.java (20) M abiquo/src/main/java/org/jclouds/abiquo/domain/network/PrivateNetwork.java (32) M abiquo/src/main/java/org/jclouds/abiquo/domain/network/PublicNetwork.java (23) M abiquo/src/main/java/org/jclouds/abiquo/domain/network/UnmanagedNetwork.java (23) M abiquo/src/main/java/org/jclouds/abiquo/domain/options/FilterOptions.java (12) M abiquo/src/main/java/org/jclouds/abiquo/domain/task/AsyncTask.java (4) M abiquo/src/main/java/org/jclouds/abiquo/features/CloudApi.java (111) M abiquo/src/main/java/org/jclouds/abiquo/features/EnterpriseApi.java (20) M abiquo/src/main/java/org/jclouds/abiquo/features/EventApi.java (16) M abiquo/src/main/java/org/jclouds/abiquo/features/InfrastructureApi.java (60) M abiquo/src/main/java/org/jclouds/abiquo/features/VirtualMachineTemplateApi.java (14) M abiquo/src/main/java/org/jclouds/abiquo/features/services/AdministrationService.java (6) M abiquo/src/main/java/org/jclouds/abiquo/features/services/CloudService.java (6) A abiquo/src/main/java/org/jclouds/abiquo/functions/pagination/BasePaginationParser.java (56) A abiquo/src/main/java/org/jclouds/abiquo/functions/pagination/ParseEnterprises.java (49) A abiquo/src/main/java/org/jclouds/abiquo/functions/pagination/ParseEvents.java (49) A abiquo/src/main/java/org/jclouds/abiquo/functions/pagination/ParseExternalIps.java (49) A abiquo/src/main/java/org/jclouds/abiquo/functions/pagination/ParsePrivateIps.java (49) A abiquo/src/main/java/org/jclouds/abiquo/functions/pagination/ParsePublicIps.java (49) A abiquo/src/main/java/org/jclouds/abiquo/functions/pagination/ParseUnmanagedIps.java (49) A abiquo/src/main/java/org/jclouds/abiquo/functions/pagination/ParseVirtualMachineTemplates.java (51) A abiquo/src/main/java/org/jclouds/abiquo/functions/pagination/ParseVirtualMachines.java (51) A abiquo/src/main/java/org/jclouds/abiquo/functions/pagination/ParseVolumes.java (50) M abiquo/src/main/java/org/jclouds/abiquo/internal/BaseAdministrationService.java (14) M abiquo/src/main/java/org/jclouds/abiquo/internal/BaseCloudService.java (15) M abiquo/src/main/java/org/jclouds/abiquo/internal/BaseEventService.java (11) M abiquo/src/main/java/org/jclouds/abiquo/predicates/VirtualDatacenterPredicates.java (7) M abiquo/src/main/java/org/jclouds/abiquo/strategy/enterprise/ListVirtualMachineTemplates.java (20) M abiquo/src/test/java/org/jclouds/abiquo/domain/cloud/AccountLiveTest.java (5) M abiquo/src/test/java/org/jclouds/abiquo/domain/cloud/VirtualDatacenterLiveApiTest.java (10) M abiquo/src/test/java/org/jclouds/abiquo/domain/cloud/VirtualMachineLiveApiTest.java (4) M abiquo/src/test/java/org/jclouds/abiquo/domain/cloud/VirtualMachineLiveTest.java (12) M abiquo/src/test/java/org/jclouds/abiquo/domain/cloud/VirtualMachineNetworkingLiveApiTest.java (63) M abiquo/src/test/java/org/jclouds/abiquo/domain/cloud/VirtualMachineStorageLiveApiTest.java (33) M abiquo/src/test/java/org/jclouds/abiquo/domain/cloud/VolumeLiveApiTest.java (16) M abiquo/src/test/java/org/jclouds/abiquo/domain/enterprise/EnterpriseLiveApiTest.java (27) M abiquo/src/test/java/org/jclouds/abiquo/domain/enterprise/TemplateDefinitionListLiveApiTest.java (4) M abiquo/src/test/java/org/jclouds/abiquo/domain/infrastructure/DatacenterLiveApiTest.java (7) M abiquo/src/test/java/org/jclouds/abiquo/domain/infrastructure/MachineLiveApiTest.java (4) M abiquo/src/test/java/org/jclouds/abiquo/domain/infrastructure/RemoteServiceLiveApiTest.java (5) M abiquo/src/test/java/org/jclouds/abiquo/domain/infrastructure/TierLiveApiTest.java (5) M abiquo/src/test/java/org/jclouds/abiquo/domain/network/ExternalNetworkLiveApiTest.java (26) M abiquo/src/test/java/org/jclouds/abiquo/domain/network/GenericNetworkLiveApiTest.java (26) M abiquo/src/test/java/org/jclouds/abiquo/domain/network/PrivateNetworkLiveApiTest.java (22) M abiquo/src/test/java/org/jclouds/abiquo/domain/network/PublicNetworkLiveApiTest.java (26) M abiquo/src/test/java/org/jclouds/abiquo/domain/network/UnmanagedNetworkLiveApiTest.java (26) M abiquo/src/test/java/org/jclouds/abiquo/environment/CloudTestEnvironment.java (29) M abiquo/src/test/java/org/jclouds/abiquo/environment/InfrastructureTestEnvironment.java (8) M abiquo/src/test/java/org/jclouds/abiquo/features/CloudApiExpectTest.java (502) M abiquo/src/test/java/org/jclouds/abiquo/features/CloudApiTest.java (209) A abiquo/src/test/java/org/jclouds/abiquo/features/EnterpriseApiExpectTest.java (141) M abiquo/src/test/java/org/jclouds/abiquo/features/EnterpriseApiTest.java (54) A abiquo/src/test/java/org/jclouds/abiquo/features/EventApiExpectTest.java (108) D abiquo/src/test/java/org/jclouds/abiquo/features/EventApiTest.java (54) M abiquo/src/test/java/org/jclouds/abiquo/features/InfrastructureApiExpectTest.java (227) M abiquo/src/test/java/org/jclouds/abiquo/features/InfrastructureApiTest.java (109) M abiquo/src/test/java/org/jclouds/abiquo/features/VirtualMachineTemplateApiExpectTest.java (53) M abiquo/src/test/java/org/jclouds/abiquo/features/VirtualMachineTemplateApiTest.java (44) M abiquo/src/test/java/org/jclouds/abiquo/strategy/cloud/ListAttachedNicsLiveApiTest.java (10) M abiquo/src/test/resources/logback-test.xml (8) A abiquo/src/test/resources/payloads/all-vms-lastpage.xml (31) M abiquo/src/test/resources/payloads/all-vms.xml (4) A abiquo/src/test/resources/payloads/available-templates-lastpage.xml (43) A abiquo/src/test/resources/payloads/available-templates-page.xml (43) A abiquo/src/test/resources/payloads/enterprises-lastpage.xml (40) A abiquo/src/test/resources/payloads/enterprises-page.xml (40) A abiquo/src/test/resources/payloads/events-lastpage.xml (40) A abiquo/src/test/resources/payloads/events-page.xml (40) A abiquo/src/test/resources/payloads/externalips-lastpage.xml (27) A abiquo/src/test/resources/payloads/externalips-page.xml (27) A abiquo/src/test/resources/payloads/privateips-lastpage.xml (17) A abiquo/src/test/resources/payloads/privateips-page.xml (17) A abiquo/src/test/resources/payloads/publicips-available-lastpage.xml (29) A abiquo/src/test/resources/payloads/publicips-available-page.xml (29) A abiquo/src/test/resources/payloads/publicips-lastpage.xml (25) A abiquo/src/test/resources/payloads/publicips-page.xml (25) A abiquo/src/test/resources/payloads/publicips-purchased-lastpage.xml (29) A abiquo/src/test/resources/payloads/publicips-purchased-page.xml (29) A abiquo/src/test/resources/payloads/templates-lastpage.xml (35) M abiquo/src/test/resources/payloads/templates-page.xml (26) A abiquo/src/test/resources/payloads/unmanagedips-lastpage.xml (29) A abiquo/src/test/resources/payloads/unmanagedips-page.xml (29) A abiquo/src/test/resources/payloads/vms-lastpage.xml (31) A abiquo/src/test/resources/payloads/vms-page.xml (31) A abiquo/src/test/resources/payloads/volumes-lastpage.xml (18) A abiquo/src/test/resources/payloads/volumes-page.xml (18) -- Patch Links -- https://github.com/jclouds/jclouds-labs/pull/24.patch https://github.com/jclouds/jclouds-labs/pull/24.diff
