> +
> +import
> org.jclouds.abiquo.domain.options.FilterOptions.BaseFilterOptionsBuilder;
> +import org.jclouds.http.options.BaseHttpRequestOptions;
> +
> +/**
> + * Available options to query users.
> + *
> + * @author Carlos Garcia
> + */
> +public class UserOptions extends BaseHttpRequestOptions {
> + public static Builder builder() {
> + return new Builder();
> + }
> +
> + @Override
> + protected Object clone() throws CloneNotSupportedException {
All options classes in Abiquo have the same clone signature.@demobox, would
it be better to change them and also address the comment about the
unnecessary variables in the builders in a separate PR, to get all them
cleaned up?
El 16/08/2013 12:07, "Carlos García Ibáñez" <[email protected]>
escribió:
> In
> abiquo/src/main/java/org/jclouds/abiquo/domain/enterprise/options/UserOptions.java:
>
> > +
> > +import
> > org.jclouds.abiquo.domain.options.FilterOptions.BaseFilterOptionsBuilder;
> > +import org.jclouds.http.options.BaseHttpRequestOptions;
> > +
> > +/**
> > + * Available options to query users.
> > + *
> > + * @author Carlos Garcia
> > + */
> > +public class UserOptions extends BaseHttpRequestOptions {
> > + public static Builder builder() {
> > + return new Builder();
> > + }
> > +
> > + @Override
> > + protected Object clone() throws CloneNotSupportedException {
>
> This clone() method has been copied from the
> EnterpriseOptions<https://github.com/jclouds/jclouds-labs/blob/master/abiquo/src/main/java/org/jclouds/abiquo/domain/enterprise/options/EnterpriseOptions.java>class.
> Since
> UserOptions is so simple (it just translates the standard pagination
> parameters into the Abiquo ones), should I change it?
>
> —
> Reply to this email directly or view it on
> GitHub<https://github.com/jclouds/jclouds-labs/pull/22/files#r5811040>
> .
>
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/22/files#r5811076
